Skip to content

fix: Use i18nTitle provided by the app in ComposerBoxPopupPreview component #35079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 7 commits into from
Feb 6, 2025
Merged

fix: Use i18nTitle provided by the app in ComposerBoxPopupPreview component #35079

kodiakhq merged 7 commits into from
Feb 6, 2025

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jan 31, 2025 •
edited
Loading

Proposed changes (including videos or screenshots)

image

Issue(s)

closes #32733

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 31, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 62b4cc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tiagoevanp tiagoevanp added this to the 7.4.0 milestone Jan 31, 2025
@tiagoevanp tiagoevanp force-pushed the fix/composer-preview-title branch from 13dbcde to 4eb0783 Compare January 31, 2025 12:33
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35079/

Built to branch gh-pages at 2025-02-04 13:36 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.22%. Comparing base (ae763a6) to head (f6e9b70).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35079      +/-   ##
===========================================
- Coverage    59.22%   59.22%   -0.01%     
===========================================
  Files         2824     2824              
  Lines        68044    67980      -64     
  Branches     15149    15117      -32     
===========================================
- Hits         40301    40259      -42     
+ Misses       24912    24892      -20     
+ Partials      2831     2829       -2
Flag Coverage Δ
unit 75.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp marked this pull request as ready for review January 31, 2025 13:49
@tiagoevanp tiagoevanp requested a review from a team as a code owner January 31, 2025 13:49
@tassoevan tassoevan force-pushed the fix/composer-preview-title branch from 224a56f to dbc0d78 Compare January 31, 2025 19:32
@tassoevan tassoevan force-pushed the fix/composer-preview-title branch from dbc0d78 to 53b8ca5 Compare February 2, 2025 00:59
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Feb 4, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 4, 2025
@tassoevan tassoevan removed the stat: QA assured Means it has been tested and approved by a company insider label Feb 4, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 4, 2025
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Feb 5, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 5, 2025
@kodiakhq kodiakhq bot merged commit 5f9adcd into develop Feb 6, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the fix/composer-preview-title branch February 6, 2025 04:39
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

Preview Title not showing up in preview component

3 participants

@tiagoevanp @tassoevan